CLI: Throw error if --requireReference and --unsafeSkipStorageCheck are both enabled
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the argument for ignoring (silently) vs throwing an "incompatible options" error ? |
|
Same concern as @Amxx, the CLI arguments are contradictory and it's not obvious what the behavior would be. |
ericglau
changed the title
requireReference if using unsafeSkipStorageCheck--requireReference and --unsafeSkipStorageCheck are both enabled
|
Thanks, I agree with the comments. Changed it to throw an error if both are enabled. |
ericglau
requested review from
Amxx and
ernestognw
and removed request for
Amxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requireReferenceoption is used for requiring a reference contract for storage compatibility checks, which contradicts withunsafeSkipStorageCheck. Throw an error if both are enabled.