Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 [Bug]: pallet_timestamp::MinimumPeriod = 0 #376

Closed
3 tasks done
4meta5 opened this issue Dec 12, 2024 · 2 comments
Closed
3 tasks done

🐞 [Bug]: pallet_timestamp::MinimumPeriod = 0 #376

4meta5 opened this issue Dec 12, 2024 · 2 comments
Assignees
@4meta5
Labels
bug Something isn't working priority: 3 We will resolve this first before everything else.

Comments

@4meta5
Copy link
Contributor

4meta5 commented Dec 12, 2024

templates

  • Generic Runtime Template
  • Evm Template

What happened?

This bug was reintroduced during the migration to pallet abstractions.

  1. approve and merge Nonzero minimum period openzeppelin-pallet-abstractions#57
  2. new release for pallet abstractions release which includes nonzero minimum period
  3. update templates abstractions to abstractions release which includes nonzero minimum period
  4. regression test to ensure the bug is never reintroduced again as per 🎁 [Feature Request]: Regression tests for bug patches #351

Expected behavior

No response

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@4meta5 4meta5 added the bug Something isn't working label Dec 12, 2024
@4meta5 4meta5 self-assigned this Dec 12, 2024
@4meta5 4meta5 added the priority: 3 We will resolve this first before everything else. label Dec 12, 2024
@4meta5 4meta5 moved this from 🗒 Backlog to 🏗 In Development in Substrate Runtime Templates Dec 12, 2024
This was referenced Dec 12, 2024
Merged
Draft
Merged
@4meta5
Copy link
Contributor Author

4meta5 commented Dec 13, 2024

Addressed on v3 in #380 but changes still need to ported to main

@4meta5 4meta5 mentioned this issue Dec 13, 2024
Closed
3 tasks
@4meta5
Copy link
Contributor Author

4meta5 commented Dec 27, 2024

Closed by #385

@4meta5 4meta5 closed this as completed Dec 27, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Development to ✅ Done in Substrate Runtime Templates Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4meta5 4meta5

Labels
bug Something isn't working priority: 3 We will resolve this first before everything else.
Projects
Substrate Runtime Templates
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V3 Fixes into Main OpenZeppelin/polkadot-runtime-templates
1 participant
@4meta5