Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonzero minimum period #380

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Nonzero minimum period #380

merged 4 commits into from
Dec 13, 2024

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Dec 12, 2024 •
edited
Loading

Addresses #376 #377 for v3 branch (not main)

Follow Up

  • open against main

@4meta5 4meta5 added the bug Something isn't working label Dec 12, 2024
@4meta5 4meta5 self-assigned this Dec 12, 2024
4meta5
4meta5 commented Dec 12, 2024
View reviewed changes
evm-template/Cargo.toml Outdated Show resolved Hide resolved
@4meta5 4meta5 mentioned this pull request Dec 12, 2024
Merged
@4meta5
Copy link
Contributor Author

4meta5 commented Dec 12, 2024

CI error is in node compilation so I do not see how it was introduced by this PR

@4meta5 4meta5 marked this pull request as ready for review December 13, 2024 13:36
KitHat
KitHat approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@KitHat KitHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is great, the only thing that is left to update deps, correct?

@4meta5
Copy link
Contributor Author

4meta5 commented Dec 13, 2024 •
edited
Loading

Everything is great, the only thing that is left to update deps, correct?

Yes, issued a new release. Pointed to it in deps, now I am compiling locally to update the Cargo.locks

@4meta5 4meta5 merged commit 035e52a into v3 Dec 13, 2024
1 of 2 checks passed
@4meta5 4meta5 deleted the amar-nonzero-min-period branch December 13, 2024 14:34
This was referenced Dec 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitHat KitHat KitHat approved these changes

Assignees

@4meta5 4meta5

Labels
bug Something isn't working
Projects
Substrate Runtime Templates
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4meta5 @KitHat