Log Handling Refactor, Improved Buffer Management, and Robust Serial Read #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace String::from_utf8_lossy().to_string() with into_owned() for better performance - Refactor RxPanel to use VecDeque<char> for efficient character-based log management - Eliminates UTF-8 character boundary issues when truncating logs - Implements circular buffer pattern for O(1) character insertion/removal - Updates serialization to work with VecDeque<char> - Add graceful error handling in serial communication thread - Handle serial read errors without panicking - Detect GUI channel disconnection and stop thread cleanly - Prevent cascade failures when GUI thread crashes Fixes crashes caused by assertion failed: self.is_char_boundary(end) when processing serial data containing invalid UTF-8 sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements and refactors to the log handling and serial communication subsystems:
Changes
Refactored Log Writing:
&[u8]) instead of converting to a string, ensuring binary data is handled correctly.write_to_filemethod inFileLogPanelnow accepts a byte slice.RxPanel Buffer Optimization:
RxPanelnow uses aVecDeque<char>for its content buffer, allowing efficient removal of old characters when the log exceeds the maximum length.append_logmethod to maintain the buffer size and performance.UI Improvements:
Serial Communication Robustness: