Join page 1124 #1794
Merged
Join page 1124 #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kylemh
reviewed
Feb 23, 2024
1 flaky test on run #4620 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Hash Links > on Corporate Sponsorship page > will change route when clicked |
Screenshots
Video
|
|
Review all test suite changes for PR #1794 ↗︎
|
Code Climate has analyzed commit 7d45293 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 74.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since there is more discussion needed for a full redesign, I just stuck with getting the "important" parts in and just do some light UX touchups.
Issue Resolved
Fixes #1124
Screenshots/GIFs
Questions or issues
The "Operation Code's Slack Community Guidelines" copy for the checkbox label is long and breaks oddly (visible in screenshots). I also noticed this behavior in other places using the
OutboundLinkcomponent (visible in screenshot below).Making the form wider fixes the wrapping issue on desktop, but on smaller screen sizes it is just going to continue to wrap oddly. Should we change copy, or should I file a feature request for the
OutboutLinkcomponent to allow better wrapping?Screenshots/GIFs