Convert Badge and Branding to Typescript #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kylemh
reviewed
Mar 1, 2024
| @@ -3,7 +3,9 @@ import Swatch from 'components/Branding/Swatch/Swatch'; | |||
| import Content from 'components/Content/Content'; | |||
|
|
|||
| function ColorSection() { | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
it's fine to have error expects in test code, but not in UI code... what's the error here?
There was a problem hiding this comment.
So, the ts error is: "Property 'primary' does not exist on type '{}'.ts(2339)", and the error flag is on brandColorsObject.primary. I think I found a way to solve the error.
|
Code Climate has analyzed commit fd0d0f2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 79.6% (-1.0% change). View more on Code Climate. |
Passing run #4639 ↗︎
Details:
Review all test suite changes for PR #1801 ↗︎ |
|||||||||||||||
kylemh
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Converting components included all test and storybook files for each.
Badgecomponent to Typescript, removed prop-types, and added a props typeBrandingcomponents to Typescript, removed prop-types, and added a props typeColorSectionFontSectionLogoSectionSwatchIssue Resolved
Fixes #NA
Screenshots/GIFs
All new .tsx files