[REFACTOR/#151] Auth 모듈 통신 관련 UseCase 패턴으로 교체 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkk5474096
reviewed
Nov 13, 2024
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| class UseCaseModule { | ||
| @Singleton |
There was a problem hiding this comment.
UseCase를 특별하게 Singleton으로 만든 이유가 있을까?.?
UseCase는 보통 상태를 가지지 않는 단일 책임 비즈니스 로직이고
이미 repository 단에서 single톤이기에 특별한 이유가 없다면 사용 안해도 될거같슴다
There was a problem hiding this comment.
오호 ... 하나의 기능 구현이라면 싱글톤이 아닌게 오히려 덜꼬일 것 같기는 하네요 !
| @InstallIn(SingletonComponent::class) | ||
| class UseCaseModule { | ||
| @Singleton | ||
| @Provides |
There was a problem hiding this comment.
yello 때는 별 뜻없이 provide를 사용하긴 했는데 외부 라이브러리 주입이 아니라면 bind로 주입하는걸 추천합니댜,
repository나 dataSource도
kkk5474096
reviewed
Nov 13, 2024
There was a problem hiding this comment.
추가로 싱글톤 제거하고 UseCase에서 Inject로 주입한다면 UseCaseModule은 제거해도 됩니다~ @Marchbreeze
Marchbreeze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description