[#43] Update #29
Annotations
3 errors and 16 warnings
Test Suite:
rpg_tools_rendering/examples/pants.rs#L33
missing field `belt` in initializer of `Pants`
|
Test Suite
could not compile `rpg_tools_rendering` (example "pants") due to previous error
|
Test Suite
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
this expression creates a reference which is immediately dereferenced by the compiler:
rpg_tools_rendering/src/rendering/equipment/footwear.rs#L86
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> rpg_tools_rendering/src/rendering/equipment/footwear.rs:86:39
|
86 | renderer.render_polygon(&polygon, &options);
| ^^^^^^^^ help: change this to: `options`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this `if let` can be collapsed into the outer `if let`:
macro_ui/src/utils.rs#L18
warning: this `if let` can be collapsed into the outer `if let`
--> macro_ui/src/utils.rs:18:29
|
18 | / ... if let Type::Path(type_path) = t {
19 | | ... return type_path.path.segments.first().map(|s| s.ident.clone());
20 | | ... }
| |_______________________^
|
help: the outer pattern can be modified to include the inner pattern
--> macro_ui/src/utils.rs:17:59
|
17 | if let Some(GenericArgument::Type(t)) = args.args.first() {
| ^ replace this binding
18 | if let Type::Path(type_path) = t {
| ^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default
|
useless use of `vec!`:
rpg_tools_core/src/ui/editor.rs#L127
warning: useless use of `vec!`
--> rpg_tools_core/src/ui/editor.rs:127:13
|
127 | &vec!["true".to_string(), "false".to_string()],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["true".to_string(), "false".to_string()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
|
useless use of `vec!`:
rpg_tools_core/src/ui/editor.rs#L114
warning: useless use of `vec!`
--> rpg_tools_core/src/ui/editor.rs:114:13
|
114 | &vec!["true".to_string(), "false".to_string()],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["true".to_string(), "false".to_string()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
|
this `if let` can be collapsed into the outer `if let`:
macro_ui/src/utils.rs#L18
warning: this `if let` can be collapsed into the outer `if let`
--> macro_ui/src/utils.rs:18:29
|
18 | / ... if let Type::Path(type_path) = t {
19 | | ... return type_path.path.segments.first().map(|s| s.ident.clone());
20 | | ... }
| |_______________________^
|
help: the outer pattern can be modified to include the inner pattern
--> macro_ui/src/utils.rs:17:59
|
17 | if let Some(GenericArgument::Type(t)) = args.args.first() {
| ^ replace this binding
18 | if let Type::Path(type_path) = t {
| ^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test Suite
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|