Fix unreliable unit test #16145
Merged
Fix unreliable unit test #16145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/OrchardCore.Tests/Apis/GraphQL/Queries/RecentBlogPostsQueryTests.cs
Outdated
Show resolved
Hide resolved
MikeAlhayek
reviewed
May 24, 2024
| // test is executing too fast, both blog entries may have the same CreatedUtc | ||
| // value and ordering becomes random. Because of this, we do not assert the order | ||
| // of the result. | ||
| Assert.Contains("Some sorta blogpost in a Query!", jsonArray.Select(node => node["displayText"]?.ToString())); |
There was a problem hiding this comment.
Can you save the result of jsonArray.Select(node => node["displayText"]?.ToString()) into a variable and use it in both lines?
MikeAlhayek
approved these changes
May 25, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16018.