Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Facebook widgets recipe migration (Lombiq Technologies: OCORE-188) #16347

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

sarahelsaig
Copy link
Contributor

Fixes #16346

@Piedone
Copy link
Member

Piedone commented Jun 19, 2024

Please try to repro the issue with YesSqlOptions.EnableThreadSafetyChecks set, what happens then? Still successful?

@sarahelsaig
Copy link
Contributor Author

Ok, I will check that too.

@Piedone Piedone changed the title Fix recipe migration. Fix Facebook widgets recipe migration (Lombiq Technologies: OCORE-188) Jun 19, 2024
@sarahelsaig
Copy link
Contributor Author

I have enabled it and tested the scenario using both SQLite and SQL Server. The logs show no problem now that the migration recipe has been fixed:

2024-06-19 19:06:44.9190|||8|Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer|WARN|The ASP.NET Core developer certificate is not trusted. For information about trusting the ASP.NET Core developer certificate, see https://aka.ms/aspnet/https-trust-dev-cert. 
2024-06-19 19:06:45.1228|||14|Microsoft.Hosting.Lifetime|INFO|Now listening on: https://localhost:5001 
2024-06-19 19:06:45.1284|||14|Microsoft.Hosting.Lifetime|INFO|Now listening on: http://localhost:5000 
2024-06-19 19:06:45.1344||||Microsoft.Hosting.Lifetime|INFO|Application started. Press Ctrl+C to shut down. 
2024-06-19 19:06:45.1344||||Microsoft.Hosting.Lifetime|INFO|Hosting environment: Development 
2024-06-19 19:06:45.1374||||Microsoft.Hosting.Lifetime|INFO|Content root path: /home/sarah/Projects/OrchardCore/src/OrchardCore.Cms.Web 
2024-06-19 19:11:50.9110|Default|00-c5b08a3d9d20dca367b8561beba9f902-aff1855bc4b9fed6-00||OrchardCore.OpenId.Configuration.OpenIdClientConfiguration|WARN|The OpenID client settings are invalid: The authority cannot be null or empty.
The response type cannot be null or empty.
The response mode cannot be null or empty. 
2024-06-19 19:11:50.9364|Default|00-c5b08a3d9d20dca367b8561beba9f902-aff1855bc4b9fed6-00||OrchardCore.Twitter.Signin.Configuration.TwitterOptionsConfiguration|WARN|Integration with Twitter is not correctly configured. 
2024-06-19 19:12:19.7184|Default|00-ada19df463dd6dab8ab2a4a39786ab30-9f3606700275785a-00||OrchardCore.Twitter.Services.TwitterSettingsConfiguration|WARN|Twitter is not correctly configured. 

@sarahelsaig
Copy link
Contributor Author

While doing the same on the main branch results no additional information as far as I can see.
orchard-log-2024-06-19.log

@Piedone Piedone merged commit 9d79ab5 into OrchardCMS:main Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database breaks when multiple features are enabled in a single recipe
2 participants