Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Collections bootstrap upgrade #3253

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

megwalt
Copy link
Contributor

@megwalt megwalt commented Jan 28, 2025

Closes #3216

Changes

  • Updates button text format on Explore tab buttons
  • Adjusts triangle indicator so that it is visible on active tab
  • Adds missing translation in 'My Collections' breadcrumb
  • Adjusts responsive layout breakpoints
  • Fixes masonry view item title text
  • Adjusts pagination layout and colors

Issues

  • Missing table view
  • Missing view type buttons
  • Masonry view icon not being set properly through config.view.masonry.icon_class
  • Missing sort fields

These issues seem to be related to changes in setting config in app/controllers/oregon_digital/explore_collections_controller.rb. Once the issues have been resolved, I can go back in and update the bootstrap/CSS.

Screenshots

Explore Collections full size window
Explore Collections mobile view

@megwalt megwalt requested a review from CGillen January 28, 2025 23:17
@CGillen CGillen merged commit 0eabffd into feature/hyrax-4 Jan 29, 2025
3 of 4 checks passed
@CGillen CGillen deleted the feature/exploreCollectionsBootstrapUpgrade branch January 29, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants