Fix Bing Maps zoom level, remove map_title template and use Bing Maps API to parse latitude and longitude#17
Fix Bing Maps zoom level, remove map_title template and use Bing Maps API to parse latitude and longitude#17hpusset wants to merge 3 commits intoOrganice:mainfrom
Conversation
bittner
left a comment
bittner
left a comment
There was a problem hiding this comment.
Thank you for your effort!
The linter complains about semicolons, can you take a look?
| @@ -1 +0,0 @@ | |||
| {% if object.title %}<h2>{{ object.title }}</h2>{% endif %} | |||
There was a problem hiding this comment.
Any particular reason why you remove this here in favor of putting more complexity in the other template?
There was a problem hiding this comment.
I think its unnecessary to create a second template just for one line and append an include to the main template.
There was a problem hiding this comment.
Fine, but keep it in a single line, just like in the template.
The idea of the separate template was to allow easy overriding. You may want to wrap the code in a {% block %} now for continued customizability.
CHANGELOG.rst
Outdated
| CHANGELOG | ||
| ========= | ||
|
|
||
| 1.0.0 (2019-06-07) |
There was a problem hiding this comment.
Is yours a breaking change that satisfies a major version jump?
I'd prefer to get more of the open issue fixed before releasing a version 1.0.
There was a problem hiding this comment.
I change this one to 0.12.0, do you agree ?
| {% include "djangocms_maps/maps_title.html" %} | ||
| {% if object.title %} | ||
| <h2>{{ object.title }}</h2> | ||
| {% endif %} |
There was a problem hiding this comment.
Please, put everything in a single line, no spacing. The HTML output has unpleasant line breaks and inconsistent indenting otherwise.
| data-lng="{% if object.lng %}{{ object.lng }}{% endif %}" | ||
| {% if object.lat and object.lng %} | ||
| data-latlng="{{ object.lat }},{{ object.lng }}" | ||
| {% endif %} |
There was a problem hiding this comment.
I'm afraid, this will break the implementation of the other map providers.
Also, please make sure the indenting of the resulting output is consistent and there are no superflous line breaks.
2 participants
No description provided.