Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter template, fix CI builds #527

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Feb 5, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updated the cookiecutter template to the latest commit
  • Updated versions of many GitHub Actions and Python dependencies
  • Removed coveralls from the CI dependencies
  • Added pre-commit hooks for vulture (dead code) and codespell (typos)
  • Grammatical errors have been addressed in several docstrings and in notebooks

Does this PR introduce a breaking change?

Not really. New hooks required some fixes (mostly typos).

Other information:

mypy will require some moderate effort to convert the code base to adopt. The hook is staged, but not enabled. No major urgency around this.

@Zeitsperre Zeitsperre self-assigned this Feb 5, 2025
@github-actions github-actions bot added CI Modifications to autiomation utilities docs labels Feb 5, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zeitsperre
Copy link
Contributor Author

@aulemahal This seems to be complaining about the French catalogues, but running $ make findfrench/translate seems to be failing for me. Was there an API change?

@aulemahal
Copy link
Collaborator

The new babel (2.17) automatically adds a "python-brace-format" comment to the po file when the translated string is a f-string. This is to be used in an upcoming (not implemented yet) check that would ensure the translation uses the same f-string variables than the source. Which sounds useful!

So I updated the po file and the translations, and pinned babel >= 2.17.

@Zeitsperre Zeitsperre merged commit c9f9f36 into drop-setuptools Feb 6, 2025
15 checks passed
@Zeitsperre Zeitsperre deleted the cookiecutter-update branch February 6, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Modifications to autiomation utilities docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants