Convert project to use CMake #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipsanen
force-pushed
the
cviljami
branch
2 times, most recently
from
525fce5 to
c0cf4fa
Compare
Collaborator
Author
|
Changed it back so it builds each dll in a separate job, which speeds the CI up quite a bit. It would be easy to make it build everything in 2 jobs (Debug/Release) but that a) is slower b) is slightly more confusing since it's no longer clear which configuration created the build error. |
lipsanen
force-pushed
the
cviljami
branch
5 times, most recently
from
2b901f5 to
605ca62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could still mess with the CI a little bit if we want, since I made the CI only have Debug/Release rather than have every combination of Debug OE, Release OE, Debug (2007), Release (2007), etc. This makes it a bit simpler but also increases the CI time from 3~ minutes to 12~ minutes, since it compiles all 4 engine branches in one config.