Fixes #434 #435
Draft
Fixes #434 #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Seems to be broken on 4104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UntitledParser uses different send prop types for protocol versions 14 & below than for 15 & above. As far as I remember this corresponds with version 5135 (which is protocol 15) - that has a DPT_VectorXY field. This adjustment takes care of strings which previously showed up as "enable to parse" since they were treated as
DPT_Array. Also, the cast for DPT_String was incorrect which fixes #434.Tested
spt_hud_ent_info 0,.*on portal 5135 & 3420.