Skip to content

Added post-process effects #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 7, 2025
Merged

Added post-process effects #330

merged 16 commits into from
Feb 7, 2025

Conversation

adriengivry
Copy link
Member

@adriengivry adriengivry commented Nov 22, 2024

Description

  • Added post-process effects (FXAA, Bloom, Auto-Exposure, Tonemapping)
  • Added PostProcessStack to manage effect settings and a new component (CPostProcessStack) to expose them
  • Updated Lua bindings
  • Added Blit method to the base renderer
  • Changed default framebuffer type to HDR (RGBA32F)
  • Added an option to render the whole scene to the stencil buffer (required for the grid to avoid drawing on top of an already rendered pixel)
  • Removed built-in tonemapping + gamma correction in PBR shader (since it's already performed as a post-processing effect)

To-Do

Screenshots

overload-post-process-stack
image
overload-tonemapping-modes
image
image
image

@adriengivry adriengivry added Feature Graphics Graphical feature labels Nov 22, 2024
@adriengivry adriengivry self-assigned this Nov 22, 2024
@adriengivry adriengivry changed the title [WIP] Added post-process effects (FXAA, Bloom) [WIP] Added post-process effects (FXAA, Bloom, Tonemapping) Nov 25, 2024
@adriengivry adriengivry mentioned this pull request Nov 26, 2024
2 tasks
@adriengivry adriengivry changed the title [WIP] Added post-process effects (FXAA, Bloom, Tonemapping) [WIP] Added post-process effects (FXAA, Bloom, Auto-Exposure, Tonemapping) Nov 27, 2024
@adriengivry adriengivry changed the title [WIP] Added post-process effects (FXAA, Bloom, Auto-Exposure, Tonemapping) [WIP] Added post-process effects Nov 27, 2024
@adriengivry adriengivry changed the base branch from develop to feature/shadow_mapping November 28, 2024 18:52
Base automatically changed from feature/shadow_mapping to develop February 7, 2025 03:50
* Added PostProcessStack to manage effect settings
* Separated effects into different classes
* Updated Lua bindings
* Added Blit method to the base renderer
…e grid can be drawn properly, excluding already rendered pixels
* fixed framebuffer wasn't properly set to HDR after resize
* removed built-in tonemapping + gamma correction in PBR shader (since it's already performed as a post-processing effect)
Copy link
Member Author

@adriengivry adriengivry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding:

  • Adjust lights (especially in asset view) so that PBR materials are as visible as blinn phong
  • Make PBR the new default?

I think these should be addressed in another PR. We should implement a system so that the asset view can select a "preview scene" (which would be setup with all the lights and post-processing the user want). By default Overload would ship with a default "preview scene", but through the settings, the user should be able to change the "preview scene" to use when previewing an asset.

Once we have proper support for PBR material preview, PBR should be made the new default.

@adriengivry adriengivry changed the title [WIP] Added post-process effects Added post-process effects Feb 7, 2025
@adriengivry adriengivry marked this pull request as ready for review February 7, 2025 15:39
adriengivry and others added 2 commits February 7, 2025 11:49
…Pass.cpp

Co-authored-by: Thibaut PONCHON <thibaut.ponchon@gmail.com>
…Stack.cpp

Co-authored-by: Thibaut PONCHON <thibaut.ponchon@gmail.com>
@adriengivry adriengivry merged commit a4f6bd7 into develop Feb 7, 2025
1 check passed
@adriengivry adriengivry deleted the feature/post_process branch February 7, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics Graphical feature
Development

Successfully merging this pull request may close these issues.

2 participants