Skip to content

Conversation

@brad-richardson
Copy link
Contributor

Category

What kind of change is this?
Please select one of the following four options.
Consult Pull request merging criteria for a description of each category.

  1. Cosmetic change.
  2. Documentation change by member.
  3. Documentation change by Overture tech writer.
  4. Material change.

Description

As noted in #286, we're "re-adding" lanes while we decide next steps for the attribute and gather additional feedback.

Reference

  1. Remove lanes #286
  2. https://github.com/OvertureMaps/tf-transportation/issues/129

Testing

Schema tests, was included previously

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Docs preview for this PR.

@brad-richardson
Copy link
Contributor Author

Great post showing the impact of (cycle) lanes and a use case: https://www.linkedin.com/posts/bilonenko_osm-vs-overture-maps-activity-7289567843593928704-PnrV

@vcschapp
Copy link
Collaborator

@brad-richardson JFYI, one issue I only just realized in talking to some Amazon folks is that our current schema doesn't handle alternating and reversible road segments because those features only existed in the lanes model that we removed in #286...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants