-
Notifications
You must be signed in to change notification settings - Fork 11
Formatted CSV for Place Categories #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
@jonahadkins could you state somewhere how were theme, topic, subtopic, niche etc. generated or determined for each category? |
I think that "RV Park" would be better than the current "Rv Park". Maybe this should be a separate file anyway, so these can be translated into other languages. Presumably these are en-US? |
canonically "RV" in most places: https://en.wikipedia.org/wiki/RV_park |
theme -> domain
| @@ -1,4 +1,4 @@ | |||
| Category,Theme,Topic,Subtopic,Niche,Variant,Subvariant,Display Name,Hierarchy Level | |||
| Category,Domain,Topic,Subtopic,Niche,Variant,Subvariant,Display Name,Hierarchy Level | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR description to strike out Theme and insert Domain per my understanding of the change.
vcschapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing I'm missing on this PR so far is:
- Why are we doing this? (What is the problem we are solving?)
- Who will use this file?
- How will the file be used?
- Why is this file the right way of solving the problem?
- What alternative solutions were considered and rejected?
- Is this file part of the schema, yes or no?
- Do we expect people to depend on it and complain if we change it?
Following from the discussion in the schema meeting last Wednesday 2025-05-21, should this PR be cycled into an RFD to try to answer those motivating questions before we review it as a PR?
|
@jonahadkins can you update this to merge to a branch per the discussion on 2025-06-11? |
Description
This PR provides future looking improvements to the existing category csv:
overture_categories.csvasoverture_category_taxonomy.csvto de-risk planned changes affecting users.overture_categories.csv, with the exception of the column names.ThemeDomain, Topic, Subtopic, Niche, Variant, Subvariant) were chosen from standard hierarchical heading names.ThemeDomain: (Level 1) A broad category that groups related types of points of interest, such as food and drink, entertainment, or shopping. There are 22 unique values.Visual Example: