Feature: Step Timings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanshing
force-pushed
the
feature-step-timings
branch
from
5c904de to
d77150d
Compare
Update predict_from_frame method to return walk windows and step timestamps. Update main function to output step timestamps. Co-authored-by: aidanacquah
chanshing
force-pushed
the
feature-step-timings
branch
from
d77150d to
fb445af
Compare
|
Awesome Aidan! I had to fix some bugs in how the timestamps were selected (it was selecting T windows regardless of whether they were walking T windows) but main ideas were there. Also had to undo the huge reformatting as otherwise it was painful to review. Finally, I made it the default to output the timestamps file. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new feature, in which a csv is outputted for the time of each detected step.
Note that to do so, this has also:
I have successfully tested this on a sample file by running:
stepcount sample.csv --step-timingsI have not updated any package versions until confirmation from @chanshing