Enhance SlotId and SlotArena for improved stability and performance#29
Merged
Enhance SlotId and SlotArena for improved stability and performance#29
SlotId and SlotArena for improved stability and performance#29Conversation
- Updated `SlotId` to include a generation counter, preventing stale handle access and ensuring safe reuse of indices. - Modified `SlotArena` to manage a separate generations vector, allowing for efficient tracking of slot reuse and enhancing the safety of `get`, `remove`, and `contains` operations. - Improved documentation to clarify the behavior of `SlotId` and its relationship with `SlotArena`, including examples demonstrating the new generation checks. - Ensured that all changes align with performance goals, maintaining O(1) complexity for access patterns while enhancing usability and safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlotIdto include a generation counter, preventing stale handle access and ensuring safe reuse of indices.SlotArenato manage a separate generations vector, allowing for efficient tracking of slot reuse and enhancing the safety ofget,remove, andcontainsoperations.SlotIdand its relationship withSlotArena, including examples demonstrating the new generation checks.Description
Related Issue
Fixes #
Type of Change
How Has This Been Tested?
Test environment:
Checklist
cargo fmtandcargo clippycargo test)Screenshots (if applicable)
Additional Notes