Wireless Rate Snapshots & Mesh Link Fixes #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wireless mesh hop stores TX/RX from the child AP's perspective, but GetDirectionalRatesFromPath() was returning them without flipping to match the direction mapping (FromDevice/ToDevice). This caused incorrect efficiency calculations for mesh AP speed tests. Added tests for GetDirectionalRatesFromPath() and IsAsymmetric().
The mesh hop stores TX/RX from the child AP's perspective, but the tooltip should display from the parent AP's perspective to be consistent with the RX=FromDevice, TX=ToDevice convention used elsewhere.
Captures Wi-Fi PHY rates during active speed tests and compares with rates at test completion, using the higher of the two values. This guards against rate fluctuations that can cause misleadingly low readings when rates collapse after traffic stops. Features: - Browser tests: JS callback captures snapshot 3 seconds into download - iperf3 client tests: snapshot captured when first direction arrives - iperf3 SSH tests: snapshot captured between Phase 1 and Phase 2 - AP roam detection: skips snapshot if client changed APs (rates not comparable) - Cache invalidation ensures fresh topology for current vs snapshot comparison Also includes: - Asymmetric link threshold lowered to 9% for more split displays - Symmetric links show the higher of Tx/Rx rates - Debug logging shows captured and compared rates
- Fix IsAsymmetric test threshold from 10% to 9% to match implementation - Add WirelessRateSnapshotTests.cs with 23 tests covering: - Model tests (dictionary init, case-insensitive MAC lookups) - Rate comparison logic (Math.Max selection) - Roaming detection (same/different AP, null handling) - Mesh device snapshot scenarios - Add SnapshotIntegrationTests.cs with 17 integration tests covering: - Asymmetric wireless client paths - Mesh AP target paths with GetDirectionalRatesFromPath - Snapshot rate selection simulation - End-to-end path analysis - MLO client snapshot handling - Add test fixtures: CreateAsymmetricWirelessClientPath, CreateMeshApTargetPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This release improves Wi-Fi speed test accuracy and fixes mesh link rate reporting.
Wireless Rate Snapshots
Mesh Link Fixes
Other
Test Plan