Fix inter-VLAN isolation audit to check inbound access directionally #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniFi's "Network Isolation" only blocks OUTBOUND traffic from isolated networks. It does NOT block INBOUND traffic to them. This fix ensures Management and Security networks are protected from inbound access regardless of their own isolation setting. Key changes: - Check inbound access to Management/Security from all relevant networks - Add FirewallRuleEvaluator to account for rule ordering (lower index = higher priority) - Validate connection state - rules only blocking INVALID don't provide isolation - Detect when allow rules eclipse block rules - Add zone matching to rule evaluation - Update recommendation messages to mention rule ordering Tests: 2779 passing (including 596 new tests)
tvancott42
force-pushed
the
feature/isolation-inbound
branch
from
0d8ba4c to
b7c1517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Isolation Direction Fix
UniFi's "Network Isolation" feature only blocks outbound traffic from isolated networks - it does NOT block inbound access. This PR fixes the audit to:
Rule Ordering Support
Firewall rules are processed by index (lower = higher priority). A block rule can be eclipsed by an allow rule with lower index. Added:
FirewallRuleEvaluatorutility class for evaluating rules with proper orderingConnection State Validation
Rules that only block
INVALIDconnection state don't provide isolation - they only clean up stale connections. Added:ConnectionStateTypeandConnectionStatesproperties to FirewallRule modelBlocksNewConnections()method to validate rules actually block new connectionsTest Plan