Reorganize volume entries in docker-compose #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the comments for the volume, anyone new to docker (there are always people who are new) will not realize their compose is failing because yaml doesn't support comments on a line of content (annoys me to this day that yaml doesn't, but hey ho)
Collaborator
|
Thanks for the PR I was curious and started to question my existence a little... so I looked, and I think the original was valid, see https://yaml.org/spec/1.2.2/#21-collections and https://yaml.org/spec/1.2.2/#22-structures |
tvancott42
force-pushed
the
main
branch
10 times, most recently
from
0e8198b to
73c7892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the comments for the volume, anyone new to docker (there are always people who are new) will not realize their compose is failing because yaml doesn't support comments on a line of content (annoys me to this day that yaml doesn't, but hey ho)