fix: 🐛 Fix storages to properly drop contents of oversized slots when…

… broken (fixes bug where these would only drop up to max stack size)
P3pp3rF1y · Dec 28, 2023 · 9ff4a39 · 9ff4a39
1 parent 5dd189d
commit 9ff4a39
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -3,7 +3,7 @@ org.gradle.daemon=false
 
 mod_id=sophisticatedcore
 mod_group_id=sophisticatedcore
-mod_version=0.5.112
+mod_version=0.5.113
 sonar_project_key=sophisticatedcore:SophisticatedCore
 github_package_url=https://maven.pkg.github.com/P3pp3rF1y/SophisticatedCore
 

diff --git a/src/main/java/net/p3pp3rf1y/sophisticatedcore/util/InventoryHelper.java b/src/main/java/net/p3pp3rf1y/sophisticatedcore/util/InventoryHelper.java
@@ -397,11 +397,12 @@ public static void dropItems(ItemStackHandler inventoryHandler, Level level, dou
 			if (stack.isEmpty()) {
 				return;
 			}
-			ItemStack extractedStack = inventoryHandler.extractItem(slot, stack.getCount(), false);
+			ItemStack extractedStack = inventoryHandler.extractItem(slot, stack.getMaxStackSize(), false);
 			while (!extractedStack.isEmpty()) {
-				Containers.dropItemStack(level, x, y, z, extractedStack.split(Math.min(extractedStack.getCount(), extractedStack.getMaxStackSize())));
-				inventoryHandler.setStackInSlot(slot, ItemStack.EMPTY);
+				Containers.dropItemStack(level, x, y, z, extractedStack);
+				extractedStack = inventoryHandler.extractItem(slot, stack.getMaxStackSize(), false);
 			}
+			inventoryHandler.setStackInSlot(slot, ItemStack.EMPTY);
 		});
 	}