Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md, fix the install command guide. #437

Closed
wants to merge 2 commits into from

Conversation

nooooocato
Copy link

Fixes #

Proposed Changes

If you do not install @types/p5 while installing this package, TypeScript development tools will not provide complete type hints.

Additional Notes (optional)

It might be better to provide a complete explanation and mention the --save-dev option, I'm not sure.

Signed-off-by: 什么喵 <kerocate_moe@outlook.com>
@jamesrweb
Copy link
Collaborator

jamesrweb commented Jul 28, 2024

Please run the format script and push the formatting fixes.

Please also have the two install steps, one for the dependencies and one for the development dependencies and add an explanation for each as you also recommend yourself ☺️.

Thank you in advance. 👍🏻

@jamesrweb
Copy link
Collaborator

Closed in favour of #457

@jamesrweb jamesrweb closed this Aug 14, 2024
@nooooocato
Copy link
Author

Please run the format script and push the formatting fixes.

Please also have the two install steps, one for the dependencies and one for the development dependencies and add an explanation for each as you also recommend yourself ☺️.

Thank you in advance. 👍🏻

Thank you. I'm sorry I saw it so late. I have no experience in open source and don't often read notifications. Anyway, #457 is good to solve it.

@nooooocato nooooocato deleted the patch-1 branch October 30, 2024 12:14
@jamesrweb
Copy link
Collaborator

No need to apologise @nooooocato, thank you so much for the contribution and I hope you do so again in future! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants