Skip to content

Limit number of commands attempted to be registered to match Discord … #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RedPanda4552 merged 1 commit into from
Jan 15, 2026
Merged

Limit number of commands attempted to be registered to match Discord … #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/main/java/net/pcsx2/hifumi/command/CommandIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,23 +138,41 @@ public void rebuildUser() {

public void rebuildDynamic() {
HashMap<String, DynamicCommand> commands = HifumiBot.getSelf().getDynCmdConfig().dynamicCommands;
int commandCount = 0;

for (String commandName : commands.keySet()) {
if (slashCommands.containsKey(commandName)) {
Messaging.logInfo("CommandIndex", "rebuildDynamic", "Skipping dynamic command \"" + commandName + "\", found a built-in command with the same name");
break;
continue;
}

if (++commandCount > 100) {
Messaging.logInfo("CommandIndex", "rebuildDynamic", "Command `/" + commandName + "` is being skipped, the limit of 100 commands has been reached.");
continue;
}

DynamicCommand command = commands.get(commandName);
SlashCommandData commandData = Commands.slash(command.getName(), command.getDescription());
HashMap<String, DynamicSubcommand> subcommands = command.getSubcommands();
int subcommandCount = 0;

for (String subcommandName : subcommands.keySet()) {
if (++subcommandCount > 25) {
Messaging.logInfo("CommandIndex", "rebuildDynamic", "Subcommand `/" + commandName + " " + subcommandName + "` is being skipped, the limit of 25 subcommands has been reached.");
continue;
}

DynamicSubcommand subcommand = subcommands.get(subcommandName);
SubcommandGroupData subgroup = new SubcommandGroupData(subcommand.getName(), subcommand.getDescription());
HashMap<String, DynamicChoice> choices = subcommand.getChoices();
int choiceCount = 0;

for (String choiceName : choices.keySet()) {
if (++choiceCount > 25) {
Messaging.logInfo("CommandIndex", "rebuildDynamic", "Choice `/" + commandName + " " + subcommandName + " " + choiceName + "` is being skipped, the limit of 25 choices has been reached.");
continue;
}

DynamicChoice choice = choices.get(choiceName);
SubcommandData subcommandData = new SubcommandData(choice.getName(), choice.getDescription());
subcommandData.addOption(OptionType.USER, "mention", "Mention");
Expand Down