UI: Move and enable by default Skip Presenting Duplicate Frames #12460
+36
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
approved these changes
Mar 27, 2025
It seems our OSD does not like updating at 0.25 per tick so let's just go back for now.
|
Can confirm the frame times are now being reported correctly. Before it was a mess of going 30 to 28 to 31 on the game fps counter Master:
Pr:
|
|
GTA San Andreas and Bully frametime doubles from 20ms average to 40 ms average with this enabled by default Enabled Disabled |
That's intentional you are seeing the frame times without the duplicate frames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves Skip Presenting Duplicate Frames from Graphics Settings Advanced to Emulation Settings Frame Pacing/Latency Control and enables it by default.
Rationale behind Changes
Our frame time graph can get very unhappy in certain FMVs in 25/30 fps games if this is not enabled and it makes frame generation less useful as it will try to generate frames from a base of 50/60 fps which is not desirable.
Suggested Testing Steps
Make sure skip duplicate frames still functions and the setting is on by default in a clean slate build.