Added non-permanent options disclaimer

PChai007 · Jan 11, 2021 · cae0a22 · cae0a22
1 parent 608d6c0
commit cae0a22
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 2 deletions.
diff --git a/CommonUtils b/CommonUtils
diff --git a/app/src/main/java/com/gianlu/aria2app/api/aria2/Aria2Helper.java b/app/src/main/java/com/gianlu/aria2app/api/aria2/Aria2Helper.java
@@ -60,6 +60,10 @@ public static Aria2Helper instantiate(@NonNull Context context) throws Initializ
         }
     }
 
+    public boolean isInAppDownloader() {
+        return client.isInAppDownloader();
+    }
+
     private void processGlobalOptionsUpdate(@NonNull JSONObject newOptions) {
         if (!client.isInAppDownloader()) return;
 

diff --git a/app/src/main/java/com/gianlu/aria2app/options/OptionsDialog.java b/app/src/main/java/com/gianlu/aria2app/options/OptionsDialog.java
@@ -139,6 +139,9 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
             return null;
         }
 
+        layout.findViewById(R.id.optionsDialog_notPermanentOptionsDisclaimer)
+                .setVisibility(helper.isInAppDownloader() ? View.VISIBLE : View.GONE);
+
         helper.request(req, this);
 
         return layout;

diff --git a/app/src/main/res/layout/dialog_options.xml b/app/src/main/res/layout/dialog_options.xml
@@ -14,6 +14,7 @@
             android:layout_width="match_parent"
             android:layout_height="match_parent"
             android:layout_marginStart="8dp"
+            android:layout_marginTop="4dp"
             android:layout_marginEnd="8dp" />
 
         <ProgressBar
@@ -24,6 +25,17 @@
             android:layout_margin="48dp" />
     </FrameLayout>
 
+    <TextView
+        android:id="@+id/optionsDialog_notPermanentOptionsDisclaimer"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginStart="4dp"
+        android:layout_marginTop="4dp"
+        android:layout_marginEnd="4dp"
+        android:text="@string/notPermanentOptionsDisclaimer"
+        android:textAlignment="center"
+        android:visibility="gone" />
+
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
@@ -37,7 +49,7 @@
             android:layout_height="wrap_content"
             android:text="@android:string/cancel" />
 
-        <View
+        <Space
             android:layout_width="0dp"
             android:layout_height="match_parent"
             android:layout_weight="1" />

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -377,4 +377,5 @@
     <string name="prefs_clearWebViewCookies">Clear WebView cookies</string>
     <string name="prefs_clearWebViewCookies_summary">Clear the cookies when the WebView is opened.</string>
     <string name="clearCookies">Clear cookies</string>
+    <string name="notPermanentOptionsDisclaimer">These options will be reset upon restart. You may want to edit them from the profile settings.</string>
 </resources>