make Trans::toreal do nothing if given real-typed data

PDLPorters · Jan 6, 2025 · b6d2f92 · b6d2f92
1 parent e8b93dd
commit b6d2f92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/Changes b/Changes
@@ -1,3 +1,5 @@
+- make Trans::toreal do nothing if given real-typed data
+
 0.432 2025-01-04
 - uses PDL 2.096+ lib/*.pd format for quicker builds
 

diff --git a/lib/PDL/LinearAlgebra/Trans.pd b/lib/PDL/LinearAlgebra/Trans.pd
@@ -850,13 +850,13 @@ sub PDL::acoth($) {my $tmp = 1/pdl($_[0]) ; $tmp->atanh}
 
 my $_tol = 9.99999999999999e-15;
 
-sub toreal{
-	return $_[0] if $_[0]->isempty;
-	$_tol = $_[1] if defined $_[1];
-	my ($min, $max, $tmp);
-	($min, $max) = $_[0]->im->minmax;
-	return $_[0]->re->sever unless (abs($min) > $_tol || abs($max) > $_tol);
-	$_[0];
+sub toreal {
+  $_tol = $_[1] if defined $_[1];
+  return $_[0] if $_[0]->isempty or $_[0]->type->real;
+  my ($min, $max, $tmp);
+  ($min, $max) = $_[0]->im->minmax;
+  return $_[0]->re->sever unless (abs($min) > $_tol || abs($max) > $_tol);
+  $_[0];
 }
 
 =head2 mlog