-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme and methods adjustment #19
Conversation
The README file is adjusted, the code is adjusted to remove the raster and an adjustment is made to validate the response when uploading the items since the error was not evident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I uploaded a full collection with 4 items for loss and persistence (name: CAZMTest-15102024).
- The collection info in the STAC is correct.
- The TIFFs are converted to COG, uploaded to Azure, and attached to items as assets.
The only issue I found is that the properties (colors, classes, values) were not correctly created for each item. The collection you previously uploaded, @denarch22, LossPersistence, does have these properties. Is it necessary to make any changes to the collection.json file when uploading the collection?
In addition, the functions to validate and remove a collection are OK.
Also remove the '>' I'm the changes description (it's explicitly said in the PR template And change the associated issue link for the GitHub link (the goal of this link is to allow people outside zenhub to see how an issue was resolved) |
readme and logs adjustment
adjust format
adjust parameter
@denarch22 the purpose of the collection spec is to simplify things for other researchers, so we need to keep the properties at the collection level, but internally those properties will be associated to each item, if each item has any other property it will be added to that specific item (or replace the one inherited from the collection). Also none of them are required in the spec. Please add these clarifications in the spec.md file (that the properties in the collection level metadata will be associated to each item in the stac collection and that if the same property is set in the collection and in the item, the item will overwrite the collection one ). Keep this file in spanish |
adjust spec
validation adjustment collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add metadata.properties.colors
to the specification of the collection in collection.md
setting properties collection and documentation
Make the adjustment again in the collection properties since they were remaining at the same level as the other properties.
Update: According to our last meeting, we realized it is not necessary to change |
Erika is not available to re-review, but we all agreed on the last changes during the noon meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing everything works fine.
🛠️ Changes
The README file is adjusted, the code is adjusted to remove the raster and an adjustment is made to validate the response when uploading the items since the error was not evident.
📝 Associated issues
Ajuste en cargue y propiedades de las colecciones