Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme and methods adjustment #19

Merged
merged 8 commits into from
Oct 21, 2024
Merged

readme and methods adjustment #19

merged 8 commits into from
Oct 21, 2024

Conversation

denarch22
Copy link
Contributor

@denarch22 denarch22 commented Oct 11, 2024

🛠️ Changes

The README file is adjusted, the code is adjusted to remove the raster and an adjustment is made to validate the response when uploading the items since the error was not evident.

📝 Associated issues

Ajuste en cargue y propiedades de las colecciones

The README file is adjusted, the code is adjusted to remove the raster and an adjustment is made to validate the response when uploading the items since the error was not evident.
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/utils/stac_rest.py Outdated Show resolved Hide resolved
src/utils/storage.py Show resolved Hide resolved
Copy link
Member

@cazapatamar cazapatamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I uploaded a full collection with 4 items for loss and persistence (name: CAZMTest-15102024).

  • The collection info in the STAC is correct.
  • The TIFFs are converted to COG, uploaded to Azure, and attached to items as assets.

The only issue I found is that the properties (colors, classes, values) were not correctly created for each item. The collection you previously uploaded, @denarch22, LossPersistence, does have these properties. Is it necessary to make any changes to the collection.json file when uploading the collection?

imagen

In addition, the functions to validate and remove a collection are OK.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@erikasv
Copy link
Member

erikasv commented Oct 16, 2024

Also remove the '>' I'm the changes description (it's explicitly said in the PR template

And change the associated issue link for the GitHub link (the goal of this link is to allow people outside zenhub to see how an issue was resolved)

@denarch22
Copy link
Contributor Author

denarch22 commented Oct 17, 2024

Subí una colección completa con 4 elementos para pérdida y persistencia (nombre: CAZMTest-15102024).

  • La información de la colección en el STAC es correcta.
  • Los TIFF se convierten en COG, se cargan en Azure y se adjuntan a los elementos como recursos.

El único problema que encontré es que las propiedades (colores, clases, valores) no se crearon correctamente para cada elemento. La colección que cargó anteriormente, , LossPersistence, tiene estas propiedades. ¿Es necesario realizar algún cambio en el archivo collection.json al cargar la colección?

imagen

Además, las funciones para validar y eliminar una colección son correctas.

yes camilo apart from the one in collection which is mandatory, it is necessary to add it to the items, like this:
image

readme and logs adjustment
adjust format
adjust parameter
@erikasv
Copy link
Member

erikasv commented Oct 17, 2024

si camilo aparte del que esta en collection que es obligatorio, es necesario agregarlo en los items, asi: image

@denarch22 the purpose of the collection spec is to simplify things for other researchers, so we need to keep the properties at the collection level, but internally those properties will be associated to each item, if each item has any other property it will be added to that specific item (or replace the one inherited from the collection). Also none of them are required in the spec.

Please add these clarifications in the spec.md file (that the properties in the collection level metadata will be associated to each item in the stac collection and that if the same property is set in the collection and in the item, the item will overwrite the collection one ). Keep this file in spanish

adjust spec
validation adjustment collection
Copy link
Member

@cazapatamar cazapatamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add metadata.properties.colors to the specification of the collection in collection.md

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
setting properties collection and documentation
Make the adjustment again in the collection properties since they were remaining at the same level as the other properties.
@denarch22 denarch22 requested a review from cazapatamar October 21, 2024 20:01
@denarch22
Copy link
Contributor Author

According to the last meeting, I made the adjustment so that the properties would remain within the collection with the extra fields option.

image

@cazapatamar
Copy link
Member

Also, please add metadata.properties.colors to the specification of the collection in collection.md

Update: According to our last meeting, we realized it is not necessary to change collection.md

@cazapatamar cazapatamar dismissed erikasv’s stale review October 21, 2024 21:53

Erika is not available to re-review, but we all agreed on the last changes during the noon meeting

Copy link
Contributor

@ManuelStardust ManuelStardust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing everything works fine.

@denarch22 denarch22 merged commit 4958cc3 into main Oct 21, 2024
1 check passed
@denarch22 denarch22 deleted the adjustmentCodeCollection branch October 21, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants