Fix MeasurementController.rename_value for multiple columns#189
Merged
dweindl merged 1 commit intoPEtab-dev:developfrom Sep 24, 2025
dweindl:fix_measurement_rename
Merged
Fix MeasurementController.rename_value for multiple columns#189dweindl merged 1 commit intoPEtab-dev:developfrom dweindl:fix_measurement_rename
MeasurementController.rename_value for multiple columns#189dweindl merged 1 commit intoPEtab-dev:developfrom
dweindl:fix_measurement_rename
Conversation
Partial fix for #187. Updating the measurement table changing a conditionId in the condition table also failed for me, although with a different error than in #187. That was related to using unsupported multidimensional indexers which is addressed here. Visualization after rename will fail due to invalid condition IDs. To be fixed elsewhere. I guess, if a condition is renamed, not only the meaurement table should be updated, but also the visualization table.
PaulJonasJost
approved these changes
Sep 24, 2025
Collaborator
PaulJonasJost
left a comment
PaulJonasJost
left a comment
There was a problem hiding this comment.
renaming works for. Visualization indeed does not update. Needs to be connected to some Signals. I would propose opening a dedicated Issue.
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #187. Updating the measurement table changing a conditionId in the condition table also failed for me, although with a different error than in #187. That was related to using unsupported multidimensional indexers which is addressed here.
Visualization after rename will fail due to invalid condition IDs. To be fixed elsewhere. I guess, if a condition is renamed, not only the measurement table should be updated, but also the visualization table.
Potentially the
something_changedsignal needs to be deferred until after all those modifications then.