Skip to content

Commit

Permalink
add more repro info to test case 0009
Browse files Browse the repository at this point in the history
  • Loading branch information
dilpath committed Jan 3, 2025
1 parent 0caef0a commit 10385e9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions test/pypesto/test_pypesto.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ def objective_customizer(obj):
obj.amici_solver.setRelativeTolerance(1e-12)


model_problem_options = {
"minimize_options": minimize_options,
"objective_customizer": objective_customizer,
}


@pytest.mark.parametrize(
"test_case_path_stem",
sorted(
Expand All @@ -72,8 +78,7 @@ def test_pypesto(test_case_path_stem):

# Run the selection process until "exhausted".
pypesto_select_problem.select_to_completion(
minimize_options=minimize_options,
objective_customizer=objective_customizer,
model_problem_options=model_problem_options,
)

# Get the best model
Expand Down
2 changes: 1 addition & 1 deletion test_cases/0009/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ N.B. This original Blasi et al. problem is difficult to solve with a stepwise me
1. performing 100 FAMoS starts, initialized at random models. Usually <5% of the starts ended at the best model.
2. assessing reproducibility. Most of the starts that end at the best model are not reproducible. Instead, the path through model space can differ a lot despite "good" calibration, because many pairs of models differ in AICc by less than numerical noise.

1 start was found that reproducibly ends at the best model. The initial model of that start is the predecessor model in this test case. However, the path through model space is not reproducible -- there are at least two possibilities, perhaps more, depending on simulation tolerances. Hence, you should expect to produce a similar `expected_summary.tsv`, but perhaps with a few rows swapped. If you see a different summary.tsv, please report (or retry a few times).
1 start was found that reproducibly ends at the best model. The initial model of that start is the predecessor model in this test case. However, the path through model space is not reproducible -- there are at least two possibilities, perhaps more, depending on simulation tolerances. Hence, you should expect to produce a similar `expected_summary.tsv`, but perhaps with a few rows swapped. If you see a different summary.tsv, please report (or retry a few times). In particular, a different summary.tsv file will have a different sequence of values in the `current model criterion` column (accounting for numerical noise).

0 comments on commit 10385e9

Please sign in to comment.