Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create standard/schema for a Model #130

Merged
merged 61 commits into from
Jan 6, 2025
Merged

Create standard/schema for a Model #130

merged 61 commits into from
Jan 6, 2025

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Dec 15, 2024 •
edited
Loading

Standards/schemas for the model space file and the problem file will come later.

dilpath and others added 30 commits November 23, 2024 02:43
@dilpath
closes #120
85f4cff
@dilpath
fix tests
5d8faac
@dilpath
update notebooks
28da0cd
@dilpath
Merge branch 'develop' into class_models
8ef45bb
@dilpath @dweindl
Update petab_select/ui.py
2926e6c 
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@dilpath @dweindl
Update petab_select/ui.py
b52fa53 
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@dilpath
track iterations; fix ModelHash.get_model; add Model.__repr__
ffaef40
@dilpath
add analysis module
4d8e36f
@dilpath
fixme: use pypesto PR branch
486260b
@dilpath
Merge branch 'develop' into analyze
e8b8ab9
@dilpath
unfix pypesto in tox.ini to use pyproject.toml
74fed0b
@dilpath
fix tests
8e799eb
@dilpath
test
7585748
@dilpath
sort iterations in group_by_iteration
05d17e8
@dilpath
add VIRTUAL_INITIAL_MODEL_HASH
eaa4796
@dilpath
method to convert Models to dataframe; update plotting code
2d8017c
@dilpath
update vis example to use iterations
529c799
@dilpath
update vis notebook
7224118
@dilpath
doc analysis methods briefly
49dc4a9
@dilpath
typo
3ec430b
@dilpath
move models criterion getter to Models; add Models.values() for b…
9432358 
…ackwards compatibility; update plot code
@dilpath
update test
53d7afe
@dilpath
add Model.hashes
ee21f64
@dilpath
test case 0009: add caveat
74398ae
@dilpath
fix notebooks
fb38d2d
@dilpath
update expected test case results
fe48416
@dilpath
start sorting of constants
1fa6579
@dilpath
refactor Model with mkstd
a7a7db6
@dilpath
add some old petab parameter helpers to Model; add default_compare
2e6828c
@dilpath
remove constraint column (constraints aren't implemented yet)
f5d0589
@dilpath dilpath marked this pull request as ready for review December 17, 2024 20:19
@dilpath dilpath changed the title Create standards/schema Create standard/schema for a Model Dec 17, 2024
@dilpath dilpath mentioned this pull request Dec 17, 2024
Closed
7 tasks
@dilpath dilpath requested a review from dweindl December 17, 2024 20:24
dweindl
dweindl approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

petab_select/candidate_space.py Show resolved Hide resolved
petab_select/model_subspace.py Outdated Show resolved Hide resolved
doc/problem_definition.rst Show resolved Hide resolved
@dilpath dilpath changed the base branch from analyze to develop January 6, 2025 15:16
@dilpath dilpath merged commit f8d94d7 into develop Jan 6, 2025
0 of 3 checks passed
@dilpath dilpath deleted the mkstd branch January 6, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilpath @dweindl