Skip to content

Replace some inplace ops in _scatter.py #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PlumBlossomMaid wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

Replace some inplace ops in _scatter.py #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e8398
Replace some inplace ops
PlumBlossomMaid Feb 9, 2026
e72ea3b
Merge branch 'main' into main
PlumBlossomMaid Feb 9, 2026
6fb582b
Replace view with reshape in broadcast function
PlumBlossomMaid Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions paddle_geometric/utils/_scatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,22 @@ def scatter(
return src.new_zeros(size)

index = broadcast(index, src, dim)
return src.new_zeros(size).scatter_add_(dim=dim, index=index, src=src)
return src.new_zeros(size).scatter_add(dim=dim, index=index, src=src)

if reduce == 'mean':
if index.numel() == 0:
return src.new_zeros(size)

count = paddle.zeros(dim_size, device=src.place)
count.scatter_add_(
count.scatter_add(
dim=0,
index=index,
src=paddle.ones(src.shape[dim], device=src.place),
)
count = count.clip(min=1)

index = broadcast(index, src, dim)
out = src.new_zeros(size).scatter_add_(dim=dim, index=index, src=src)
out = src.new_zeros(size).scatter_add(dim=dim, index=index, src=src)

return out / broadcast(count, out, dim)

Expand Down Expand Up @@ -173,7 +173,7 @@ def broadcast(src: paddle.Tensor, ref: paddle.Tensor,
dim: int) -> paddle.Tensor:
dim = ref.dim() + dim if dim < 0 else dim
size = (1, ) * dim + (-1, ) + (1, ) * (ref.dim() - dim - 1)
return src.view(size).expand_as(y=ref)
return src.reshape(size).expand_as(y=ref)


def scatter_argmax(
Expand Down