Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring BA sigma for ignor_state #197

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Ignoring BA sigma for ignor_state #197

merged 1 commit into from
Dec 10, 2024

Conversation

JanosJiri
Copy link
Contributor

ignore_state was not operational for couplings='baeck-an' since this was natively done in set_tocalc().

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (e9ea14a) to head (b2730a8).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   92.83%   92.84%           
=======================================
  Files          47       47           
  Lines        6759     6760    +1     
  Branches      763      764    +1     
=======================================
+ Hits         6275     6276    +1     
  Misses        472      472           
  Partials       12       12           
Flag Coverage Δ
unittests 20.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/surfacehop.F90 98.01% <100.00%> (+<0.01%) ⬆️

@JanosJiri JanosJiri linked an issue Dec 10, 2024 that may be closed by this pull request
@JanosJiri JanosJiri marked this pull request as ready for review December 10, 2024 10:54
@JanosJiri
Copy link
Contributor Author

The bug fix was tested by Jack and no errors concerning ignore_state were spotted. Ready for review!

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for a quick fix! 👏

@JanosJiri JanosJiri merged commit a781b39 into master Dec 10, 2024
19 checks passed
@JanosJiri JanosJiri deleted the ba_ignore_state branch December 10, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with "ignore_state" not working with Baeck-An couplings
2 participants