File::getDeclarationName(): prevent incorrect result during live coding #816
+93
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `function` keyword for a closure is normally tokenized as `T_CLOSURE`, but will be tokenized as `T_FUNCTION` in case of an unfinished closure declaration (no scope opener/closer). For an unfinished closure with typed parameters, the `File::getDeclarationName()` method would incorrectly return the contents of the first `T_STRING` in the type declaration as if it were the name of the function. Fixed now. Includes test.
|
FYI: Build failure is unrelated to this PR, but has to do with an outage at Coveralls. See lemurheavy/coveralls-public#1791 and https://status.coveralls.io/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetDeclarationNameTest: move parse error test to separate file
File::getDeclarationName(): prevent incorrect result during live coding
The
functionkeyword for a closure is normally tokenized asT_CLOSURE, but will be tokenized asT_FUNCTIONin case of an unfinished closure declaration (no scope opener/closer).For an unfinished closure with typed parameters, the
File::getDeclarationName()method would incorrectly return the contents of the firstT_STRINGin the type declaration as if it were the name of the function.Fixed now.
Includes test.
Suggested changelog entry
File::getDeclarationName(): prevent incorrect result for unfinished closures during live coding
Related issues/external references
Loosely related to #152
Types of changes