add defined test on some constants to avoid PHP Notice error when using c...

[metfan]

I experienced some "PHP Notice constant xxx already defined in..."
I added defined() test on these constants.

[MarkBaker]

Under what circumstances have you experienced these errors? The autoloader should ensure that the file is only ever included once... if you're getting "Already defined" errors for those constants, then it's symptomatic of a more serious problem with the autoloader, and I'd rather fix that than "patch over" the problem with an if !defined test to see if the constants are already defined

[metfan]

I had this problem when I launch functionnal test under PHPUnit with @runTestsInSeparateProcesses
I use PHPExcel in Symfony2 application with liuggio/ExcelBundle

[MarkBaker]

Ah, that explains it... our own unit tests always use the autoloader, so we don't see that issue

[metfan]

Do you me to add defined() control on all constants?