This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Excel2007 writer's save() should return TRUE when file is successfully closed #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should be put in place for all the other writers too, just haven't done this yet. Want to know if there's some form of coding practice you have in place that prevents these functions from returning a value before I put any time into modifying the other writers.
As it stands now, there is no way of knowing whether or not the
save
was successful. Or am I missing something? Should I be using atry
-catch
block?