This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Fix character encoding issue when saving for csv #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do specifically tell people always to use UTF-8 encoding |
|
The user is responsible?.. This can't be really a serious answer right? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code assumes by default that the encoding is 'UTF-8', causes a bug when trying to parse inputs from CSV for the character ü, in the word für.
Say my machine's input is ISO-8851, then iconv would have suppressed and truncate the string as 'ü' is not a valid charset of 'UTF-8'.