Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak for AMORDEGRC #4164

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Tweak for AMORDEGRC #4164

merged 3 commits into from
Sep 15, 2024

Commits on Sep 7, 2024

  1. Tweak for AMORDEGRC

    Changes to Php8.4 floating point calculations caused failures in unit tests for ROUNDDOWN, ROUNDUP, and AMORDEGRC. These were addressed in a kludgey manner by PR PHPOffice#3897. Then someone reported a problem (not specifically related to Php8.4) with TRUNC. That was fixed by PR PHPOffice#4115, in which I applied the method used by TRUNC to ROUNDDOWN and ROUNDUP as well. The method used to fix these was to cast a floating point value to string and then cast it back to float again. It's a bit surprising that this works, but it seems effective for all our test cases, and is less kludgey than what had been done earlier. Missing from that PR was a similar change for AMORDEGRC. This PR applies that change to AMORDEGRC, which again passes the unit test suite for all releases of Php.
    oleibman committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a25775a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0f811f View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    90162a1 View commit details
    Browse the repository at this point in the history