Fix last column with relative/absolute flags #607
Conversation
|
@PowerKiKi the unit tests were not broken by my changes. Currently your develop branch is broken (2 errors from unit tests). I add some unit tests for this bugfix and push it this weekend. |
|
@PowerKiKi can you explain in which case the readBIFF8CellRangeAddressB function is used? In my regular project xls file this function is called by an cell with sum function with a range reference. I reconstruct the case from this project xls file but always readBIFF8CellRangeAddress is called. What is the different between tArea and tAreaN? With this information I can create a unit test with an xls file because I can publish the xls from my project. |
|
@PowerKiKi I add the unit test for this bugfix and fix the other unit tests with a update for dompdf (from 0.8.0 to 0.8.2). |
| $calculatedValue = 'empty'; | ||
| } | ||
|
|
||
| throw new \Exception($cellCoordinate . ' != ' . $result . ' - Result in sheet with name ' . $sheetName . ' is ' . $calculatedValue . '.'); |
There was a problem hiding this comment.
This should be a proper assertion such as self::assertSame
| */ | ||
| public function testLoadXlsWithoutCellReference() | ||
| { | ||
| $filename = './data/Reader/Xls/without_cell_reference.xls'; |
There was a problem hiding this comment.
We strive to limit the number of binary files in the repository to keep its size down. Can you replace those with by writing them with PhpSpreadsheet and then reloading them instead ? (this is why I suggested functional tests, see \PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This supersedes PR PHPOffice#607 by @christian-forgacs, who deserves all the credit for reporting the problem and devising the solution. The PR went stale in 2018, and it is just easier to resubmit a clean version rather than clean up the old one. Among the suggestions in the PR was that you should try to create a spreadsheet from scratch to demonstrate the problem rather than supply one. However, my attempts to match the failing spreadsheet do not have a problem when they are read. So, a supplied spreadsheet it is. Fix PHPOffice#1570. No sample spreadsheet was supplied with that issue, but I am almost certain that this is another example of the same problem. I am removing the stale label from that issue; it will be closed properly when this PR is merged.
|
Superseded by PR #4140. |
This is:
Checklist:
Why this change is needed?
If you read a xls file and in this file you use an absolut reference in SUM function e.g. =SUM(SHEET!A1:SHEET!B1) the script only returns =SUM(SHEET!A1:SHEET!A1)