Skip to content

Conversation

@damhuonglan
Copy link
Contributor

@damhuonglan damhuonglan commented Jan 15, 2026

What does this PR do?

The segmentation faults in PH5 file might come from running out of resources in server since it is inconsistent.
This PR try to use a safer number of families to avoid that.
In the current master branch, number of family is logical + 1 which is in higher peak memory and more likely to makes segfaults. (in ph51 number of family is 49)
In this branch, number of family has been changed to half of physical cores; fallback to half of logical. (in ph51 number of family is 12)
For ph51 server the current

Relevant Issues?

#554

Checklist

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests pass.
  • Any new or changed features have are documented.
  • Changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@hrotman-pic hrotman-pic self-requested a review January 15, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant