Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request creates TorV3 Address parsing functionality. TorV2 was depreciated nearly 2 years ago and should not have access to the Tor network anymore. Therefore we need to support TorV3 for users now in SPMT.
Problems still arise, because this work relies on the work done in this PR as well: PIVX-Project/PIVX#2873
SPMT uses
decodemasternodebroadcast
andrelaymasternodebroadcast
which get updated in the above PR.We have removed TorV2 checks entirely because they should not be functional.
Successful Broadcast Creation:


Successfully Started:
Verification on daemon:
Key things to TorV3 address parsing:
Network ID as a PREFIX is 0x04 in determining its a TORV3 address through network messages
Version is always '\x03' which is the 'd' at the end of the .onion address (last char before .onion)
Length is always 62 characters and 35 bytes length.