Skip to content

[GUI] TorV3 Support #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

Liquid369
Copy link
Member

This pull request creates TorV3 Address parsing functionality. TorV2 was depreciated nearly 2 years ago and should not have access to the Tor network anymore. Therefore we need to support TorV3 for users now in SPMT.

Problems still arise, because this work relies on the work done in this PR as well: PIVX-Project/PIVX#2873

SPMT uses decodemasternodebroadcast and relaymasternodebroadcast which get updated in the above PR.

We have removed TorV2 checks entirely because they should not be functional.

Successful Broadcast Creation:
image
Successfully Started:
image
Verification on daemon:

{
  "txhash": "07b9b7beeb74c0bcef1d004c83b1ff741f776f2e4a6b6e8cf78ce7b8970d7b53",
  "outputidx": 0,
  "netaddr": "ovt6bxnzdj6afty22ccayzkuxnhhfuqjbn5gubmps4velhsxbmct6qyd.onion:51472",
  "addr": "DRndVQTocPwbPGRUzCUeFhXu36NerLsBHR",
  "status": 4,
  "message": "Masternode successfully started"
}

Key things to TorV3 address parsing:
Network ID as a PREFIX is 0x04 in determining its a TORV3 address through network messages
Version is always '\x03' which is the 'd' at the end of the .onion address (last char before .onion)
Length is always 62 characters and 35 bytes length.

@Liquid369 Liquid369 self-assigned this Jul 14, 2023
@Fuzzbawls Fuzzbawls added this to the 0.6.4 milestone Jul 15, 2023
@Fuzzbawls Fuzzbawls added the enhancement New feature or request label Jul 15, 2023
@Liquid369 Liquid369 force-pushed the 2023_torv3_support branch 4 times, most recently from 3234111 to 914128b Compare July 25, 2023 16:26
@Liquid369 Liquid369 force-pushed the 2023_torv3_support branch from 79c3450 to 76fb659 Compare March 26, 2024 01:16
@Fuzzbawls Fuzzbawls changed the title TorV3 Support [GUI] TorV3 Support Apr 5, 2024
Copy link
Contributor

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 76fb659

@Fuzzbawls Fuzzbawls merged commit a174531 into PIVX-Project:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants