Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific reasons for failed task submission #218

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Add specific reasons for failed task submission #218

merged 7 commits into from
Feb 27, 2025

Conversation

1daidai1
Copy link
Collaborator

image
image
image

@1daidai1 1daidai1 mentioned this pull request Dec 10, 2024
Merged
@1daidai1
Copy link
Collaborator Author

后端PKUHPC/CraneSched#375

@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from bc90356 to d31e903 Compare December 10, 2024 08:40
@1daidai1
Copy link
Collaborator Author

已提交

@1daidai1 1daidai1 requested a review from Nativu5 December 19, 2024 09:09
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
Nativu5
Nativu5 requested changes Feb 23, 2025
View reviewed changes
@RileyWen RileyWen force-pushed the dev/addsubmitreason branch from ba7484a to 87ed629 Compare February 23, 2025 08:36
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from ae2c825 to cfdcc7e Compare February 26, 2025 02:17
@1daidai1
Add specific reasons for failed task submission

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7231644
@1daidai1
change proto
d499870
@1daidai1
change proto errcode
ebb52c8
@1daidai1
fix qos resource enum
362fb64
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from cfdcc7e to 362fb64 Compare February 26, 2025 02:22
L-Xiafeng
L-Xiafeng reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@L-Xiafeng L-Xiafeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没其他问题了

protos/PublicDefs.proto Outdated

ERR_MAX_JOB_COUNT_PER_USER = 65;
ERR_USER_NO_PRIVILEGE = 66;
ERR_CODE_COUNT = 67;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__ERR_CODE_COUNT

@L-Xiafeng
style: Change CraneErrCode::__ERR_CODE_COUNT
e8fa0cb 
Signed-off-by: lijunlin <xiafeng.li@foxmail.com>
@Nativu5 Nativu5 merged commit 3a650af into master Feb 27, 2025
@Nativu5 Nativu5 deleted the dev/addsubmitreason branch February 27, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RileyWen RileyWen

@L-Xiafeng L-Xiafeng

@Nativu5 Nativu5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1daidai1 @RileyWen @Nativu5 @L-Xiafeng @huerni