Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supply cqueue/cinfo -o output #228

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

supply cqueue/cinfo -o output #228

wants to merge 7 commits into from

Conversation

1daidai1
Copy link
Collaborator

@1daidai1 1daidai1 commented Dec 26, 2024 •
edited
Loading

image
image
image

L-Xiafeng
L-Xiafeng reviewed Jan 3, 2025
View reviewed changes
internal/cqueue/cqueue.go Outdated Show resolved Hide resolved
@L-Xiafeng
Copy link
Collaborator

L-Xiafeng commented Jan 3, 2025 •
edited
Loading

cacct的选项也对应补齐一下吧，然后这都有很多switch case，考虑下要不要用表驱动去做，不然看起来很麻烦，对每一种做个format函数，这样以后改也方便。

@L-Xiafeng
Copy link
Collaborator

cacct的选项也对应补齐一下吧，然后这都有很多switch case，考虑下要不要用表驱动去做，不然看起来很麻烦，对每一种做个format函数，这样以后改也方便。

以及上述所有新增/已有选项都要有对应的测试样例

@L-Xiafeng L-Xiafeng mentioned this pull request Jan 6, 2025
Closed
@1daidai1
Copy link
Collaborator Author

1daidai1 commented Jan 7, 2025

已处理

@1daidai1 1daidai1 force-pushed the dev/cqueue branch 2 times, most recently from 6357634 to 2f0ba44 Compare January 7, 2025 03:04
L-Xiafeng
L-Xiafeng reviewed Jan 9, 2025
View reviewed changes
internal/cinfo/cinfo.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Xiafeng L-Xiafeng L-Xiafeng left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1daidai1 @L-Xiafeng