Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancel task not free qos res #425

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: cancel task not free qos res #425

merged 2 commits into from
Jan 23, 2025

Conversation

huerni
Copy link
Collaborator

@huerni huerni commented Jan 23, 2025

No description provided.

@huerni huerni added the bug Something isn't working label Jan 23, 2025
@huerni huerni requested a review from NamelessOIer January 23, 2025 04:33
NamelessOIer
NamelessOIer requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@NamelessOIer NamelessOIer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在这里修改会增加 pending map 加锁时长和 ccancel 命令运行时长，建议放到 CleanCancelQueueCb_ 完成

@NamelessOIer NamelessOIer merged commit 07217a2 into master Jan 23, 2025
1 check failed
@NamelessOIer NamelessOIer deleted the fix/cancel_not_free_qos_res branch January 23, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamelessOIer NamelessOIer NamelessOIer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huerni @NamelessOIer