♻️ Refactor: Update method names for improved clarity (#195) #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(src/plaid/containers/sample.py):
* Renamed methods: show_tree -> show_mesh, init_tree -> init_mesh, add_tree -> add_mesh, del_tree -> del_mesh, link_tree -> link_mesh
* Added @deprecated decorators to old methods for backward compatibility
* Corrected _links and _paths initialization in add_mesh to fix KeyError
* refactor(tests/containers/test_sample.py):
* Updated method calls (ex: sample.add_tree -> sample.add_mesh)
* Renamed fixtures (ex: sample_with_tree -> sample_with_mesh, tree -> mesh)
* Updated fixture usage in test functions
* refactor(tests/containers/test_dataset.py):
* Updated fixture usage (dataset_with_samples_with_tree -> dataset_with_samples_with_mesh)
* refactor(tests/pipelines/test_sklearn_block_wrappers.py):
* Updated fixture usage (dataset_with_samples_with_tree_nodes_feat_ids -> dataset_with_samples_with_mesh_nodes_feat_ids)
* refactor(tests/utils/test_cgns_helper.py):
* Updated fixture usage (sample_with_tree -> sample_with_mesh, tree -> mesh)
* refactor(tests/conftest.py):
* Renamed fixtures (tree -> mesh, sample_with_tree -> sample_with_mesh, samples_with_tree -> samples_with_mesh, dataset_with_samples_with_tree -> dataset_with_samples_with_mesh)
* Updated fixture usage (heterogeneous_dataset)
* refactor(tests/utils/test_stats.py):
* Updated method calls (s.init_tree -> s.init_mesh)
* refactor(examples/):
* Updated method calls (ex: sample.add_tree -> sample.add_mesh, sample.show_tree -> sample.show_mesh)
* refactor(benchmarks/):
* Updated method calls (ex: new_sample.add_tree -> new_sample.add_mesh, new_sample.link_tree -> new_sample.link_mesh)
* refactor(docs/notebooks):
* Updated notebook examples to use mesh instead of tree
* docs(CHANGELOG.md):
* Added entry for tree → mesh refactor (#111)
…ods in benchmarks
* Renamed Dataset/Sample methods: - from_tabular → add_features_from_tabular - from_features_identifier → extract_dataset_from_identifier - from_features_identifier → extract_sample_from_identifier
|
Review these changes at https://app.gitnotebooks.com/PLAID-lib/plaid/pull/205 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Hmm, strange |
|
I don't understand, was the PR closed by mistake? |
|
No sorry, seems like there was an issue with the branches and I diverged from #191 instead of main. I'll try the PR again, it should work now. |
|
Yes, we just merged a big PR that modifies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #195: Refactors method names for improved clarity:
Dataset.from_tabular→Dataset.add_features_from_tabularDataset.from_features_identifier→Dataset.extract_dataset_from_identifierSample.from_features_identifier→Sample.extract_sample_from_identifierChecklist