-
Notifications
You must be signed in to change notification settings - Fork 4
♻️ Modernize the Hugging Face bridge #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
casenave
wants to merge
21
commits into
datasets_roadmap
Choose a base branch
from
hf_splits
base: datasets_roadmap
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,709
−409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
xroynard
reviewed
Sep 30, 2025
tests/bridges/temp2.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this file ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
PR Summary
This PR modernizes the Hugging Face bridge by:
DatasetDict
: leverage the native split mechanism for efficient partial dataset access.problem_definition
andinfos
in the dataset description; provide clear functions to load/save them via JSON and YAML.HF PLAID datasets conversion
Current PLAID datasets can be downloaded, converted and uploaded with:
Results here
Then:
gives:
Splits
These modification drop the support for "subsplits": we only rely on "main split", the one defined natively through the DatasetDict. Hence,
splits
in problem_definition are ignored by the Hugging Face bridge.🔗 Related issues
Addresses tasks from
#160
#241
#219