Working Scene References #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working scene references on my end, hopefully it works for y'all too. In addition to SceneController.cs and StartMenuManager.cs I modified the Scene UI Container in the StartMenu scene to use the scene references (see screenshot), but I didn't add the file because I don't trust myself not to have accidentally edited other important things. I figure it'd be a lot safer if one of you guys went in and made the change when testing.
I don't know of any other magic numbers for changing scenes, but it's possible some still exist in the codebase that I don't know of.
Sorry for not explaining how I did this. I have to go to bed, and hope you guys can look at the code changes and get a general sense. If any parts of the implementation + the comments I wrote don't make sense, just reply to this and I can clarify tomorrow.
But for a quick comment on that, the core setup is in SceneController, and StartMenuManager is an example of how to use the scene references.