Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Correct import paths in tests #33

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[FIX] Correct import paths in tests #33

merged 1 commit into from
Dec 13, 2024

Conversation

PPeitsch
Copy link
Owner

@PPeitsch PPeitsch commented Dec 13, 2024 •
edited by coderabbitai bot
Loading

⚡ Have you read the Contributing Guidelines?

Description

Fix imports in test files to ensure proper package resolution and test execution:

  • Remove 'src.' prefix from imports across all test files
  • Standardize import paths to use installed package structure
  • Maintain consistent imports across test suite

This change resolves test failures in CI/CD pipeline related to package imports.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • I have followed the project's coding style guidelines
  • I have added tests to cover my changes
  • All new and existing tests pass locally
  • I have updated the documentation accordingly
  • I have added type hints where applicable
  • I have updated the CHANGELOG.md
  • My changes generate no new mypy warnings
  • I have checked code formatting with black (line length 100)
  • I have run isort for import sorting
  • My PR is based on the latest main branch and has no conflicts
  • I have added/updated docstrings in NumPy format

Summary by CodeRabbit

  • Bug Fixes

    • Updated import paths for various methods and classes across multiple test files to ensure correct referencing.

  • Chores

    • Restructured module import paths for better organization without altering test logic or functionality.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 13, 2024 •
edited
Loading

Walkthrough

This pull request primarily involves updating import statements across several test files to reflect a restructuring of the module's directory. The import paths have been changed from a prefixed src directory to a direct package path, simplifying how various classes and functions are referenced within the test suite. The structure, logic, and functionality of the tests remain unchanged, ensuring that all tests continue to validate their respective methods accurately.

Changes

File Change Summary
tests/test_custom_importer.py Import path updated: from src.pkynetics.data_import import CustomImporter → from pkynetics.data_import import CustomImporter
tests/test_freeman_carroll_method.py Import path updated: from src.pkynetics.model_fitting_methods import ( ... ) → from pkynetics.model_fitting_methods import ( ... )
tests/test_friedman_method.py Import path updated: from src.pkynetics.model_free_methods import friedman_method → from pkynetics.model_free_methods import friedman_method
tests/test_horowitz_metzger_method.py Import path updated: from src.pkynetics.model_fitting_methods import ( ... ) → from pkynetics.model_fitting_methods import ( ... )
tests/test_importers.py Import path updated: from src.pkynetics.data_import import dsc_importer, tga_importer → from pkynetics.data_import import dsc_importer, tga_importer
tests/test_jmak_method.py Import path updated: from src.pkynetics.model_fitting_methods import jmak_equation, jmak_method → from pkynetics.model_fitting_methods import jmak_equation, jmak_method
tests/test_kas_method.py Import path updated: from src.pkynetics.model_free_methods import kas_method → from pkynetics.model_free_methods import kas_method
tests/test_kissinger_method.py Import path updated: from src.pkynetics.model_fitting_methods.kissinger import ( ... ) → from pkynetics.model_fitting_methods.kissinger import ( ... )
tests/test_ofw_method.py Import path updated: from src.pkynetics.model_free_methods.ofw_method import ofw_method → from pkynetics.model_free_methods.ofw_method import ofw_method

Possibly related PRs

  • fixed kissinger method implementation and test #12: The changes in tests/test_custom_importer.py involve a similar modification of the import path from src.pkynetics.data_import to pkynetics.data_import, directly relating to the main PR's focus on the CustomImporter class import path.
  • Fix names and improve JMAK method and equation #20: The changes in tests/test_jmak_method.py also reflect a modification in the import path from src.pkynetics.model_fitting_methods to pkynetics.model_fitting_methods, indicating a similar restructuring as seen in the main PR.

🐰 In the meadow, paths anew,
Imports changed, fresh as dew.
Tests still run, all is well,
Validations cast their spell.
Hopping forward, bright and spry,
With each change, we reach for the sky! 🌼

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f22d7b and 5bb629e.

📒 Files selected for processing (9)
  • tests/test_custom_importer.py (1 hunks)
  • tests/test_freeman_carroll_method.py (1 hunks)
  • tests/test_friedman_method.py (1 hunks)
  • tests/test_horowitz_metzger_method.py (1 hunks)
  • tests/test_importers.py (1 hunks)
  • tests/test_jmak_method.py (1 hunks)
  • tests/test_kas_method.py (1 hunks)
  • tests/test_kissinger_method.py (1 hunks)
  • tests/test_ofw_method.py (1 hunks)
✅ Files skipped from review due to trivial changes (9)
  • tests/test_kissinger_method.py
  • tests/test_ofw_method.py
  • tests/test_freeman_carroll_method.py
  • tests/test_custom_importer.py
  • tests/test_jmak_method.py
  • tests/test_horowitz_metzger_method.py
  • tests/test_importers.py
  • tests/test_kas_method.py
  • tests/test_friedman_method.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PPeitsch PPeitsch linked an issue Dec 13, 2024 that may be closed by this pull request
Project Infrastructure Setup (Phase 1) #29
Closed
27 tasks
@PPeitsch
[FIX] Correct import paths in tests
5bb629e 
- Remove 'src.' prefix from imports
- Fix import structure for proper package resolution
- Ensure consistent import paths across all tests
@PPeitsch PPeitsch merged commit 7480045 into main Dec 13, 2024
6 checks passed
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

see 10 files with indirect coverage changes

@coderabbitai coderabbitai bot mentioned this pull request Dec 13, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Infrastructure Setup (Phase 1)
1 participant
@PPeitsch